PR Health

Build ✅

esbuild: packages/core/src/index.ts -> packages/core/lib/index.js
esbuild: packages/danbooru/src/index.ts -> packages/danbooru/lib/index.js
esbuild: packages/e621/src/index.ts -> packages/e621/lib/index.js
esbuild: packages/gelbooru/src/index.ts -> packages/gelbooru/lib/index.js
esbuild: packages/konachan/src/index.ts -> packages/konachan/lib/index.js
esbuild: packages/local/src/index.ts -> packages/local/lib/index.js
esbuild: packages/lolibooru/src/index.ts -> packages/lolibooru/lib/index.js
esbuild: packages/lolicon/src/index.ts -> packages/lolicon/lib/index.js
esbuild: packages/moehu/src/index.ts -> packages/moehu/lib/index.js
esbuild: packages/pixiv/src/index.ts -> packages/pixiv/lib/index.js
esbuild: packages/safebooru/src/index.ts -> packages/safebooru/lib/index.js
esbuild: packages/sankaku/src/index.ts -> packages/sankaku/lib/index.js
esbuild: packages/yande/src/index.ts -> packages/yande/lib/index.js

Lint ✅

Checking formatting...
All matched files use Prettier code style!

Thank you very much for your contribution. Here are some issues I noticed:

• There is no management of side effects for the package using the Node addon, which can disrupt Koishi's HMR and subsequent update operations.
• The resizing method should be independent rather than coupled with the toBase64 method.
• Please respect the original coding style.

Some thoughts on potential solutions:

• For packages with strong platform dependencies like Node addon/gyp, try to avoid using them and instead opt for packages written purely in JavaScript or manage the Node addon.
• toBase64 is just one method of sending images for booru and should not be forcibly coupled.

Reference:

https://koishi.chat/zh-CN/cookbook/design/storage.html#%E5%BA%94%E5%BD%93%E9%81%BF%E5%85%8D%E7%9A%84%E6%83%85%E5%86%B5

https://forum.koishi.xyz/t/topic/1930

另外，有部分 api 支持返回不同尺寸或大小的图片。如果有，应当优先使用 api 所提供的。

另外，有部分 api 支持返回不同尺寸或大小的图片。如果有，应当优先使用 api 所提供的。

原本逻辑应该就是优先使用 api 所提供的大小吧。我只是加了如果超过选择的大小就自动缩放，这是可选的。

但我之前用的时候发现就算选了large,meidum，图片有时候都特别大超过15mb，图源是pixiv,lolicon。

现在再看看怎么样

jimp存在内存和性能问题，考虑再看看有没有其它可以用的库
jimp-dev/jimp#153
jimp-dev/jimp#915

有时会出现maxMemoryUsageInMB limit exceeded by at least 10MB.的报错

明天试试用canvas能不能实现

明天试试用canvas能不能实现

Use canvas might be a better idea since many users have it installed.

Since there are image read / write libraries like pngjs and jpeg-js, it is also not hard to just implement a resize algorithm based on similarity between pixels though.

By the way, you should also add this option into the document, in this case, it would go to the page https://github.com/koishijs/koishi-plugin-booru/blob/main/docs/zh-CN/config.md

现在应该可以了吧

等等，似乎还要优化一下，我看puppeteer的 toBuffer是基于 toDataURL实现的，多了不必要的base64转换

应该可以了